Skip to content

gh-85984: Major revision of the pty library. - #101833

Closed
8vasu wants to merge 2 commits into
python:mainfrom
8vasu:pty_revision
Closed

gh-85984: Major revision of the pty library.#101833
8vasu wants to merge 2 commits into
python:mainfrom
8vasu:pty_revision

Conversation

@8vasu

@8vasu 8vasu commented Feb 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This follows #92365. This is one in a series of PRs aimed at cleaning-up, fixing bugs in, introducing new features in, and updating the code in "Lib/pty.py".

This is expected to fail before the following prerequisites are merged: #101832 and #102413.

Signed-off-by: Soumendra Ganguly soumendraganguly@gmail.com

@8vasu
Major revision of the pty library.
dc6a90d 
Signed-off-by: Soumendra Ganguly <soumendraganguly@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Feb 11, 2023
Open
This was referenced Feb 11, 2023
Merged
Merged
@8vasu

8vasu commented Feb 11, 2023

Copy link
Copy Markdown
Contributor Author

@gpshead This is the main set of changes in this series, but it will not work without
the prerequisites mentioned in the main comment. I am only creating this for your
reference (this explains a lot of the changes/additions in the prerequisite PRs).

8vasu
8vasu commented Feb 11, 2023
View reviewed changes
Comment thread Lib/pty.py
fds = [master_fd, STDIN_FILENO]
while fds:
rfds, _wfds, _xfds = select(fds, [], [])
while True:

@8vasu 8vasu Feb 11, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that fds is ever empty in this loop. Therefore, I replaced while fds: with the original while True:. Please correct me if I am wrong.

@8vasu
8vasu marked this pull request as draft February 12, 2023 23:10
@8vasu 8vasu mentioned this pull request Mar 4, 2023
Merged
@8vasu 8vasu mentioned this pull request Feb 4, 2024
Merged
@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@ambv

ambv commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This PR is blocked on its author, has not been touched by a human in more than 3 years, and no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on gh-85984.

@ambv ambv closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@8vasu @ambv @bedevere-bot