[Yzi-Li]

• Issue: zipfile tests: some files are left opened #137589

[StanFromIreland]

Hello, thanks however a PR was already opened for both files yesterday, #138080.

[Yzi-Li]

But there are still some file objects that have not been closed in that PR.

[StanFromIreland]

You are closing files that should not be opened, if they are opened the test is broken anyway as the error (with assertRaises(error):) is not raised. For some other cases, when a zipfile is opened in a width block, e.g. with zipfile.ZipFile(...) as zf: it is automatically closed, you can think of it as there being an automatic finally: zf.close().

[Yzi-Li]

I see, thanks.