Repository navigation
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
profiling.sampling, exception mode (--mode exception) wrote an empty profile when the thread blocked inside anexceptblock, for example intime.sleep(). The CLI also enabled the collector'sskip_idlefilter, which keeps only threads that hold the GIL or are on CPU, and a sleeping thread is neither. The unwinder already keeps only threads with an active exception, so exception mode doesn't need that filter.Lib/profiling/sampling/cli.py: new_skip_idle_for_mode()replaces the inline expression at the four places that computedskip_idle(run,attach, live run, live attach). It returnsFalsefor wall, all and exception mode andTrueotherwise, so CPU and GIL modes are unchanged.Lib/test/test_profiling/test_sampling_profiler/test_cli.py:test_skip_idle_mode_mappingchecks the mapping.test_exception_mode_captures_blocked_handlerprofiles a script that sleeps in anexceptblock and checks that the collapsed output contains the script; it fails without the change (empty output).Tests:
PCbuild/amd64/python_d.exe -m test test_profiling.test_sampling_profiler.test_cli(57 tests)PCbuild/amd64/python_d.exe -m test test_profiling.test_sampling_profiler.test_modes(15 tests)