Skip to content

gh-159973: Highlight soft keywords after token.NL / token.DEDENT - #159992

Open
johnslavik wants to merge 2 commits into
python:mainfrom
johnslavik:gh-159973-soft-keyword-highlighting
Open

gh-159973: Highlight soft keywords after token.NL / token.DEDENT#159992
johnslavik wants to merge 2 commits into
python:mainfrom
johnslavik:gh-159973-soft-keyword-highlighting

Conversation

@johnslavik

@johnslavik johnslavik commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@github-project-automation github-project-automation Bot moved this to Todo in Sprint Oct 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
Open
@johnslavik johnslavik added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 20, 2026
@NekoAsakura

This comment was marked as resolved.

Sign in to view
@johnslavik johnslavik changed the title gh-159973: Highlight soft keywords after token.NL gh-159973: Highlight soft keywords after token.NL / token.DEDENT Oct 21, 2026
@johnslavik

johnslavik commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

Thank you @NekoAsakura!

NekoAsakura
NekoAsakura approved these changes Oct 21, 2026
View reviewed changes

@NekoAsakura NekoAsakura left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Oct 21, 2026
@johnslavik

johnslavik commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

There's still false positives like match() or case =, brewing on those

@NekoAsakura

NekoAsakura commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I put together the failing patterns I found below, and it might be worth a separate PR to fix them.
pr159992_soft_keyword_bugs

Edit: case = looks fine on my end.

@johnslavik

johnslavik commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

case = looks fine on my end. -- sorry, I meant case even outside of match, which you caught above as well. Thank you for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NekoAsakura NekoAsakura NekoAsakura approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes sprint

Projects

Sprint
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnslavik @NekoAsakura