Repository navigation
[3.14] gh-155813: Stop overwriting LIBFFI_CFLAGS and LIBFFI_LIBS on macOS (GH-156486) - #160130
Merged
Merged
Conversation
…cOS (pythonGH-156486) Ensures that a user-specified LIBFFI_CFLAGS and LIBFFI_LIBS is honored when building on macOS. (cherry picked from commit 6839f8c) Co-authored-by: Advit Arora <advitarora2@gmail.com>
miss-islington
requested review from
corona10 and
erlend-aasland
as code owners
October 21, 2026 22:13
This was referenced Oct 21, 2026
freakboy3742
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that a user-specified LIBFFI_CFLAGS and LIBFFI_LIBS is honored when
building on macOS.
(cherry picked from commit 6839f8c)
Co-authored-by: Advit Arora advitarora2@gmail.com