Repository navigation
gh-159739: Preserve large years in time conversions - #160175
Open
jelle-openai wants to merge 2 commits into
Open
jelle-openai wants to merge 2 commits into
jelle-openai wants to merge 2 commits into
Conversation
The time module added 1900 to the C library year using int arithmetic, which overflowed for timestamps whose calendar year exceeds INT_MAX. On platforms that accept these timestamps, gmtime(), localtime(), and ctime() could report a negative year; perform the addition in a wider type. Backport to 3.15 and 3.14.
jelle-openai
requested review from
StanFromIreland and
pganssle
as code owners
October 22, 2026 04:15
Member
There was a problem hiding this comment.
Won't datetime have the same issue?
| SET_ITEM((INDEX), PyLong_FromLong((long) (VAL))) | ||
|
|
||
| SET(0, p->tm_year + 1900); | ||
| SET_ITEM(0, PyLong_FromLongLong((long long)p->tm_year + 1900)); |
Member
There was a problem hiding this comment.
This fixes the forward direction, but gettmarg() still reads the year into a C int:
Lines 908 to 910 in e60a9da
We should preserve the round trip.
Time tuple consumers parsed calendar years as C int before subtracting 1900, so they rejected valid struct_time results. Date and datetime timestamp conversion could also overflow before reporting the invalid year. Preserve the full time tuple range and report oversized datetime years correctly. Backport to 3.15 and 3.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time module added 1900 to the C library year using int arithmetic, which overflowed for timestamps whose calendar year exceeds INT_MAX. On platforms that accept these timestamps, gmtime(), localtime(), and ctime() could report a negative year; perform the addition in a wider type. Backport to 3.15 and 3.14.