Repository navigation
gh-159739: Propagate float rounding allocation failures - #160195
Merged
StanFromIreland merged 2 commits intoOct 22, 2026
Merged
StanFromIreland merged 2 commits into
StanFromIreland merged 2 commits into
Conversation
If the decimal-to-binary conversion inside round(float, ndigits) runs out of memory, it returns a -1.0 error sentinel and sets errno to ENOMEM. Ignoring that error can return -1.0 as a seemingly successful rounded value. Raise MemoryError instead. Backport to 3.15 and 3.14.
| _Py_SET_53BIT_PRECISION_END; | ||
| if (errno == ERANGE && fabs(rounded) >= 1.) | ||
| if (errno == ENOMEM) | ||
| PyErr_NoMemory(); |
Member
There was a problem hiding this comment.
Can we follow PEP 7 please?
The float rounding allocation-failure check extended an unbraced conditional chain, contrary to the C style required for modified code. Add braces to its branches without changing their behavior. Backport to 3.15 and 3.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the decimal-to-binary conversion inside round(float, ndigits) runs out of memory, it returns a -1.0 error sentinel and sets errno to ENOMEM. Ignoring that error can return -1.0 as a seemingly successful rounded value. Raise MemoryError instead. Backport to 3.15 and 3.14.