Skip to content

feat: throw exception on getRandomString when length < 1 #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rancoud merged 1 commit into from
Oct 23, 2026
Merged

feat: throw exception on getRandomString when length < 1 #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Crypt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,10 @@ public static function getOptionsBcrypt(): array
*/
public static function getRandomString(int $length = 64, ?string $characters = null): string
{
if ($length < 1) {
throw new CryptException(\sprintf('Length must be greater than 0: %d', $length));
}

$initialCharacters = null;
if ($characters !== null) {
$initialCharacters = static::getCharactersForRandomString();
Expand Down
12 changes: 12 additions & 0 deletions tests/CryptTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,9 @@ public function testGetRandomString(): void
$randomString = Crypt::getRandomString();
static::assertSame(64, \mb_strlen($randomString));

$randomString = Crypt::getRandomString(1);
static::assertSame(1, \mb_strlen($randomString));

$randomString = Crypt::getRandomString(105);
static::assertSame(105, \mb_strlen($randomString));

Expand All @@ -297,6 +300,15 @@ public function testGetRandomString(): void
static::assertNotSame('a', Crypt::getCharactersForRandomString());
}

/** @throws CryptException */
public function testInvalidLengthGetRandomStringCryptException(): void
{
$this->expectException(CryptException::class);
$this->expectExceptionMessage('Length must be greater than 0: 0');

Crypt::getRandomString(0, '');
}

/** @throws CryptException */
public function testGetRandomStringCryptException(): void
{
Expand Down
Loading