Android: why is Image#fadeDuration not an opt-in feature so it's consistent with iOS? #10194

Activity

1. christopherdro

   added

   Android

   on Oct 16, 2016
2. lacker commented on Dec 17, 2016

   

   lacker

   on Dec 17, 2016

   Contributor

   More actions

   Thanks for bringing this up! I suspect this is to make things feel more native, to act like the underlying platform does. At this point making it opt-in would be a breaking change and I don't think that is worth it.
3. lacker

   closed this as completedon Dec 17, 2016
4. guyca commented on Dec 17, 2016

   

   guyca

   on Dec 17, 2016

   More actions

   Would be nice to have this feature opt-out. I managed to prevent the fade animation by wrapping my <Image /> with a custom ViewGroupManager and setting ReactImageView.mFadeDuration to zero with reflection before the Image is added to the custom ViewGroup.

   Something like this:

   public class NoFadeImageWrapper extends ViewGroup {
       public NoFadeImageWrapper(Context context) {
           super(context);
       }
   
       @Override
       public void onViewAdded(View child) {
           if (child instanceof ReactImageView) {
               ((ReactImageView) child).setFadeDuration(0);
               ReflectionUtils.setField(child, "mIsDirty", true);
               ((ReactImageView) child).maybeUpdateView();
           }
           super.onViewAdded(child);
       }
   }

   ReflectionUtils.setField implementation:

   public class ReflectionUtils {
       public static void setField(Object obj, String name, Object value) {
           try {
               Field field = getField(obj.getClass(), name);
               if (field == null) {
                   return;
               }
               field.setAccessible(true);
               field.set(obj, value);
           } catch (Exception e) {
               e.printStackTrace();
           }
       }
   }
5. DylanVann commented on Jan 29, 2017

   

   DylanVann

   on Jan 29, 2017

   Contributor

   More actions

   fadeDuration is a prop on Image for android now. This is not documented.
6. gre commented on Jan 29, 2017

   

   gre

   on Jan 29, 2017

   ContributorAuthor

   More actions

   @DylanVann yeah, it's possible to override fadeDuration, but in this issue I was just asking why the default is 300ms where I think it should be 0ms if we ever want iOS and Android to be consistent.
   the workaround is to define your own Image and override the defaults but I wish there would be a better way to set that default globally at least.
7. DylanVann commented on Jan 29, 2017

   

   DylanVann

   on Jan 29, 2017

   Contributor

   More actions

   @gre yeah I agree it should probably be consistent. Just mentioning that I don't think @guyca 's solution is necessary.

   Just use:

   <Image fadeDuration={0} {...otherProps} />
   

   👍React with 👍10Reacted by Mido, Guy Carmeli, woowalker, Jay C, Neo Marvel, Shiny Lee, Josh Balfour, Pk13055, Mujtaba Fadhil and Juwan Wheatley

   🎉React with 🎉5Reacted by Mido, woowalker, Shiny Lee, arkin and avocadowastaken
8. guyca commented on Jan 29, 2017

   

   guyca

   on Jan 29, 2017

   More actions

   @DylanVann Thanks a lot! Obviously that was a hack since I wasn't aware of fadeDuration
9. sahrens commented on Dec 5, 2017

   

   sahrens

   on Dec 5, 2017

   Contributor

   More actions

   It's generally better to match platform standards rather than try to be pixel identical, so this is how we try to make the defaults. But of course you should also pay close attention to the design on both platforms and dial them in the way you want. For high quality multi-platform apps, only about 85-90% of code is shared, and the remaining 10-15% is needed to make the app conform to platform specifics.
10. react

    locked as resolved and limited conversation to collaborators on Jul 19, 2018
11. react-native-bot

    added

    Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.

    on Jul 19, 2018