Repository navigation
Conversation
huntie
marked this pull request as ready for review
October 20, 2026 15:54
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D126430803. |
Collaborator
|
This pull request was successfully merged by @huntie in 954a7c2 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Linux systems without unprivileged user namespaces (e.g. Ubuntu 23.10+), Chromium launches child processes through the
chrome-sandboxhelper, and the space in the app path (React Native DevTools-linux-x64/) breaks that launch, so DevTools crashes on startup. On 0.83 this surfaced as "An unknown error occurred while installing React Native DevTools".Package the Linux app as
react-native-devtools(react-native-devtools-linux-<arch>/react-native-devtools), the usual Linux executable naming. macOS and Windows are unchanged, and the runtime app name stays "React Native DevTools", so the window title and~/.config/React Native DevToolsuser data dir are preserved.Notes
packages/debugger-shell/bin/react-native-devtoolsis generated from published binaries; its Linuxpathentries change with the next binary update.chrome-sandboxowned by root with mode 4755; this removes the failure that remains once it is.Fixes #54906
Changelog:
[General][Fixed] - React Native DevTools: Fix launch failure when Chromium uses the SUID sandbox (Linux)
Test Plan:
Ran
node scripts/debugger-shell/build-binary.json Debian 13 (x86_64); Linux output isreact-native-devtools-linux-{x64,arm64}/react-native-devtools. Served the x64 build through a local DotSlash file and launched it viaunstable_spawnDebuggerShellWithArgswith--disable-namespace-sandboxto force the SUID sandbox path (chrome-sandboxroot, 4755):LaunchProcess: failed to execvp: …/React,FATAL:zygote_host_impl_linux.cc:207@react-native/debugger-shell v0.87.0-mainℹ️ Debian 13, not Ubuntu; SUID fallback forced by flag rather than AppArmor. macOS packaging fails on Linux hosts (Icon Composer), unrelated to this change.