Skip to content

Fix whitespace in React Native DevTools Linux app path #59232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Fix whitespace in React Native DevTools Linux app path #59232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/debugger-shell/build-binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ const platformConfigs = [
platform: ['linux'],
arch: ['x64', 'arm64'],
icon: path.join(ICON_BASE, 'icon.png'),
// Chromium's Linux SUID sandbox launch splits the chrome-sandbox path on
// whitespace, so the Linux app directory and executable must not contain
// spaces. See https://github.com/react/react-native/issues/54906.
name: APP_NAME.toLowerCase().replaceAll(' ', '-'),
},
];

Expand Down Expand Up @@ -98,9 +102,9 @@ async function main() {
await Promise.all(
platformConfigs.map(platformConfig =>
packager({
name: APP_NAME,
...platformConfig,
dir: PACKAGE_ROOT,
name: APP_NAME,
appVersion: pkg.version,
appCopyright: COPYRIGHT,
appCategoryType: 'public.app-category.developer-tools',
Expand Down
Loading