Repository navigation
Corrected types of page_info return value in documentation. - #16830
thekevinbrown wants to merge 2 commits into
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Can you sign the cla? |
|
@chirag04, I've signed it now. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@facebook-github-bot shipit |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@chirag04 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in #15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes react/react-native#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in #15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes react/react-native#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
Motivation
I was confused by the current documentation, as it was requesting me to pass the previously received
end_cursorinto the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs.I tried to push this change back in #15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR.
Test Plan
This is a change to documentation only.
Release Notes
[DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the
start_cursorandend_cursorvalues.