Repository navigation
Conversation
We did not update the cache key when buck was downgraded to 09, and this prevents us from testing with the 11 version
@facebook-github-bot label Needs more information @facebook-github-bot label Needs more information @facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
No need to use branch in cache keys when checksum is used, ensures cache hits in PRs, forks when checksummed files have not changed
We were previously omitting BUCK defs from the cache key, which could result in new deps not being pulled. Also, separate out buck fetches so it is clear which step is being performed in Circle UI
Upon further inspection, this cache is not contributing much. Fix flow issues
This has been recently added to Node 8.x. Since it makes our tests to fail, I decided to do a workaround that works for all the versions. Submitted by @grabbou.
@facebook-github-bot label Needs more information @facebook-github-bot label Needs more information @facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Not 100% there yet but landing to clear out some already-resolved errors on master. |
Summary: WIP. Closes react/react-native#17295 Differential Revision: D6628523 Pulled By: hramos fbshipit-source-id: ac2833e99de9e94340b8027469cc74a5b7379962
WIP.