Repository navigation
Use reference Yoga CMake build for libyogacore - #37371
Closed
NickGerleman wants to merge 1 commit into
Closed
NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
Base commit: f5759d7 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 05:37
b931573 to
c3ee77b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 11, 2023
Summary: X-link: react/react-native#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: 0c250d6aaa8298205fc94fd980953f51659197de
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 11, 2023
Summary: Pull Request resolved: react#1291 X-link: react/react-native#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: f3fcbe98eea6a4f87cb6305448e35dd5856852d7
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 06:00
c3ee77b to
2364c14
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 06:06
2364c14 to
41fb92a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 06:17
41fb92a to
345e464
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 07:20
345e464 to
6f80a35
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 07:26
6f80a35 to
29dd827
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 07:41
29dd827 to
dc32593
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 07:53
dc32593 to
4bf7b9a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 08:26
4bf7b9a to
4197691
Compare
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 09:09
4197691 to
a828ef3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 09:46
a828ef3 to
bd16f78
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
Summary: X-link: react/yoga#1291 Pull Request resolved: react#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings. Changelog: [Android][Changed] - Use reference Yoga CMake Build Reviewed By: cortinico Differential Revision: D45764537 fbshipit-source-id: a98c85033c219df7e55365aa8358a516a0c45fc0
NickGerleman
force-pushed
the
export-D45764537
branch
from
May 11, 2023 14:25
bd16f78 to
4e2e217
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
Contributor
|
This pull request has been merged in 6764ada. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This makes React Native use
libyogacoreas provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally.Differential Revision: D45764537