Skip to content

Defer transformed TextInput edits outside UIKit delegate callbacks (#59188) #59188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
+837 −119
Closed

Defer transformed TextInput edits outside UIKit delegate callbacks (#59188) #59188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/Libraries/Text/React-RCTText.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Pod::Spec.new do |s|

s.dependency "Yoga"
s.dependency "React-Core/RCTTextHeaders", version
add_dependency(s, "React-featureflags")

mark_as_react_native_build(s)
end
15 changes: 15 additions & 0 deletions packages/react-native/Libraries/Text/TextInput/Multiline/RCTUITextView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@

#import <React/RCTBackedTextInputDelegateAdapter.h>

@interface RCTBackedTextViewDelegateAdapter (PendingTextInputEdit)
- (void)invalidatePendingTextInputEdit;
- (void)schedulePendingTextInputEditWithRange:(NSRange)range replacementText:(NSString *)replacementText;
@end

@implementation RCTUITextView {
UILabel *_placeholderView;
UITextView *_detachedTextView;
Expand Down Expand Up @@ -207,6 +212,16 @@ - (void)setSelectedTextRange:(UITextRange *)selectedTextRange notifyDelegate:(BO
[super setSelectedTextRange:selectedTextRange];
}

- (void)rct_invalidatePendingTextInputEdit
{
[_textInputDelegateAdapter invalidatePendingTextInputEdit];
}

- (void)rct_enqueueTextInputEditWithRange:(NSRange)range replacementText:(NSString *)replacementText
{
[_textInputDelegateAdapter schedulePendingTextInputEditWithRange:range replacementText:replacementText];
}

// After restoring the previous cursor position, we manually trigger the scroll to the new cursor position (PR 38679).
- (void)scrollRangeToVisible:(NSRange)range
{
Expand Down
Loading
Loading