Repository navigation
Conversation
Static CocoaPods Debug builds often omit DEBUG=1 on hermes-engine, so the triplicated GCC_PREPROCESSOR_DEFINITIONS grep kept Release hermesvm while React-hermes compiled with HERMES_ENABLE_DEBUGGER=1. Centralize CONFIG detection on CONFIGURATION / POD_CONFIGURATION_DEBUG / DEBUG=1.
Template CI installs react-native from the packed tarball; the new helper must be listed in package.json files or the Hermes Replace script phase fails with "No such file or directory".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes the triplicated
DEBUG=1grep that picks Debug vs Release for Hermes / React-Core-prebuilt / ReactNativeDependencies swap script phases.Under static CocoaPods, Debug builds often omit
DEBUG=1onhermes-engine, so CONFIG stayed Release (no-CDPhermesvm) whileReact-hermescompiled withHERMES_ENABLE_DEBUGGER=1— undefinedfacebook::hermes::cdp::CDPDebugAPI::*at link. Speculative PR for the design in #59116; happy to rework if you'd rather a different shape.scripts/xcode/resolve-prebuilt-configuration.sh— prefers$CONFIGURATION == Debug/$POD_CONFIGURATION_DEBUG == YES, keepsDEBUG=1as fallback (Make hermes build fetching more flavour resilient #41055 intent).HERMES_ENABLE_DEBUGGER=1(not in the shared helper — RNCore/RNDeps don't care).Marker unification (always extract when
.last_build_configurationis missing on RNCore/RNDeps) left as a follow-up, same as the issue proposal.Repro: https://github.com/mikehardy/rn59116-debug-hermes-swap-repro (
./scripts/repro-ios-debug.sh)Changelog:
[IOS] [FIXED] - Share one Debug/Release CONFIG resolver for Hermes / RNCore / RNDeps prebuilt swaps
Test Plan:
packages/react-native/scripts/xcode/resolve-prebuilt-configuration.shsmoke cases (CONFIGURATION / POD_CONFIGURATION_DEBUG / DEBUG=1 / default Release)noderunner forscripts/__tests__/resolve-prebuilt-configuration-test.jscases (same matrix)DEBUG=1force after verifying)