Repository navigation
Conversation
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D126318143. |
Collaborator
|
This pull request was successfully merged by @cortinico in fcd141c When will my fix make it into a release? | How to file a pick request? |
|
@cortinico merged this pull request in fcd141c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SwiftPM artifact setup currently fails an entire CI lane when a Maven response stalls mid-body. This change:
.downloadfiles before retrying, so a retry cannot reuse truncated content.Changelog:
[INTERNAL] [FIXED] - Retry stalled SwiftPM artifact downloads
Diagnosis
maincommitf1f516e8cb2f6c085bcc08838066b5b49c08da3bfailedtest_ios_spm_rntester / test (Debug)in job https://github.com/react/react-native/actions/runs/39353507614/job/118412160607. The Hermes release artifact stopped at 8.0 MB of 24.2 MB and 0 KB/s for about ten minutes before Node fetch reportedterminated.This is a transport flake rather than a deterministic source regression:
mainworkflow runs (38/38 checks);Because the failure is nondeterministic and independent of the commit contents, a code bisect cannot identify a meaningful introducing commit. Searches of open PRs and prior CI-monitor runs found no existing fix for this stalled-download signature. PR #59068 mentions the downloader only in its diagnosis and changes different prebuild files.
Test Plan
node --check packages/react-native/scripts/spm/download-spm-artifacts.jsnpx -y prettier@3.9.4 --write packages/react-native/scripts/spm/download-spm-artifacts.js packages/react-native/scripts/spm/__tests__/download-spm-artifacts-test.js(no changes)jest --runInBand packages/react-native/scripts/spm/__tests__/download-spm-artifacts-test.js— 76/76 tests passed, including transient stream retry, idle-body retry, partial-file cleanup, and fail-fast HTTP 404 coverageRisk and limitations
A genuinely slow transfer that makes no progress for 60 seconds is restarted, which may add up to roughly two minutes plus backoff before the final failure. The retry is bounded and final errors are still surfaced; deterministic 4xx responses are not retried. Full RNTester/Xcode CI was not reproduced locally because the failure is in remote transport rather than compilation.