Repository navigation
Derive multiline TextInput state from props - #59218
Open
cipolleschi wants to merge 2 commits into
Open
cipolleschi wants to merge 2 commits into
cipolleschi wants to merge 2 commits into
Conversation
…oad the correct commit data. Differential Revision: D126072650
Summary: Use `TextInputProps::multiline` as the source of truth for multiline checks instead of inferring it from the backed UIKit class. This keeps responder offset and selection restoration logic aligned with the declarative props. Changelog: [Internal] Differential Revision: D126285220
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126285220. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Use
TextInputProps::multilineas the source of truth for multiline checks instead of inferring it from the backed UIKit class. This keeps responder offset and selection restoration logic aligned with the declarative props.Changelog: [Internal]
Differential Revision: D126285220