Repository navigation
Conversation
cortinico
marked this pull request as ready for review
October 20, 2026 10:45
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D126318404. |
Collaborator
|
This pull request was successfully merged by @cortinico in fa2baa2 When will my fix make it into a release? | How to file a pick request? |
|
@cortinico merged this pull request in fa2baa2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Allow Analyze Pull Request to recognize both
## Changelogand## Changelog:in PR descriptions. The PR template uses a colon, but a properly tagged changelog under a heading without one was incorrectly reported as missing. Preserve the existing colon format and requirement for a tagged entry. Remove the stateful global flag from the internal changelog pattern so repeated validations agree.Changelog:
[INTERNAL] [FIXED] - Accept changelog headings with or without a colon in PR validation.
Test Plan:
yarn test .github/workflow-scripts/__tests__/validatePRBody-test.js --runInBand --silent— passed (6 tests).yarn prettier .github/workflow-scripts/validatePRBody.js .github/workflow-scripts/__tests__/validatePRBody-test.js --check— passed.yarn lint— passed.git diff --check— passed.No UI changes; screenshots are not applicable.