Repository navigation
Conversation
…droid C++ Summary: Two C++ files built into RN-Tester include public React Native headers directly instead of through their module umbrella, which is an `#error` under `RN_STRICT_API`: - `rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.cpp`, - `react/debug/react_native_assert.h`, - The checked-in codegen output of `react-native/popup-menu-android` (`Props.cpp`) included `react/renderer/core/PropsParserContext.h` and `propsConversions.h`. No behavior change; this prepares RN-Tester to build with `RN_STRICT_API` by default. Changelog: [Internal] Differential Revision: D126328619
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126328619. |
|
This pull request has been merged in c99c491. |
Collaborator
|
This pull request was successfully merged by @coado in c99c491 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Two C++ files built into RN-Tester include public React Native headers directly instead of through their module umbrella, which is an
#errorunderRN_STRICT_API:rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.cpp,react/debug/react_native_assert.h,react-native/popup-menu-android(Props.cpp) includedreact/renderer/core/PropsParserContext.handpropsConversions.h.No behavior change; this prepares RN-Tester to build with
RN_STRICT_APIby default.Changelog: [Internal]
Differential Revision: D126328619