Avoid multiple component registrations #5

Activity

1. Archmonger commented on Aug 19, 2021

   

   Archmonger

   on Aug 19, 2021

   Last edited by Archmonger

   Contributor

   More actions

   Accidentally commented on the wrong issue before, so I'm reposting here

   ---

   Caching the register function with functools.cache would provide the same ability to skip re-registration, and would allow us to skip the sys.modules check. Could be slightly more performant than checking IDOM_REGISTERED_COMPONENTS.
2. Archmonger commented on Aug 31, 2021

   

   Archmonger

   on Aug 31, 2021

   Last edited by Archmonger

   Contributor

   More actions

   Note: recently discovered there is no performance penalty for importing a module more than one time. Apparently importlib already does a sys.modules check. Which means we can remove this LOC.

   See here for more details.
3. Archmonger

   added a commit that references this issue on Sep 22, 2021

   prevent duplicate component registration fix reactive-python#5

   This issue will close once commit f17ba96 is merged into the 'main' branch.

   f17ba96
4. Archmonger

   linked a pull request that will close this issueAdvanced Websocket Features #17on Sep 22, 2021
5. Archmonger

   linked a pull request that will close this issueAuto populate IDOM component registry #24on Oct 30, 2021
6. Archmonger

   removed a link to a pull requestAdvanced Websocket Features #17on Oct 30, 2021
7. Archmonger

   closed this as completedin 9336098on Nov 1, 2021