Skip to content

Review process #5

Open
Open

Description

@ltmylinh

This issue is created to discuss about review process:

  • How many approvals do we need for a PR?
  • Who will take responsibility to merge PR?

Activity

  1. nampdn commented on Feb 9, 2019

    @nampdn
    Contributor
    • To make the review process solid, I think we should have at least 1 approval.

    • At this time, we are only 2 maintainers, I think both of us can merge if a PR is approved.

  2. ltmylinh commented on Feb 9, 2019

    @ltmylinh
    CollaboratorAuthor

    I prefer at least 2 approvals. More reviewers will have good quality.
    We have @anhphamduy in our team, right?

  3. Quynh-Nguyen commented on Feb 28, 2019

    @Quynh-Nguyen
    Contributor

    @nampdn @ltmylinh
    Hi bros,
    Can I join this project? I will help translate at night.

  4. huyqdang commented on Mar 20, 2019

    @huyqdang

    Yo yo, I want to help as well.

  5. added a commit that references this issue on Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions