Repository navigation
C# integration tests - #182
Merged
Merged
Conversation
Updates restsharp support following their breaking changes, reported in Kong#312
| // there to be only one file with top-level code in any project, so we'll | ||
| // keep this project around but copy each fixture in as Program.cs | ||
| // - run Program.cs and return the output | ||
| shell.execSync(`cp ${fixturePath} /src/IntTestCsharp/Program.cs`); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
| request: Request | ||
| ) { | ||
| test(`should return the expected response for \`${fixture}\``, () => { | ||
| const basePath = path.join('src', 'targets', targetId, clientId, 'fixtures', `${fixture}${extname(targetId)}`); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
| // there to be only one file with top-level code in any project, so we'll | ||
| // keep this project around but copy each fixture in as Program.cs | ||
| // - run Program.cs and return the output | ||
| shell.execSync(`cp ${fixturePath} /src/IntTestCsharp/Program.cs`); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
| if (EXEC_FUNCTION[targetId]) { | ||
| stdout = EXEC_FUNCTION[targetId](basePath); | ||
| } else { | ||
| stdout = shell.execSync(format(targetCLI, basePath)); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
- go-httpbin is using my local tag bc of mccutchen/go-httpbin#123 - go-httpbin incorrectly thinks our requests are coming in on plain http. Possibly https://stackoverflow.com/a/61446922 is the answer? - getting close
.json() will parse the output _out_ of json and print it as a python object, which our integration tests cannot then parse
I'm not sure why it builds locally but not on gh
- This broke a lot of other tests This reverts commit 0d6670d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
node_modules🧬 QA & Testing
Provide as much information as you can on how to test what you've done.