[jgwest]

What does this PR do?

Courtesy of claude:

1. 1-002-validate_backend_service_test.go + 1-026-validate_backend_service_permissions_test.go — both had an identical It("validates backend service permissions", ...) checking the same cluster Deployment/Service in openshift-gitops. Merged into 1-002, folding in 026's ServiceAccount/ClusterRole/ClusterRoleBinding assertions. Deleted 1-026.

2. 1-105_validate_default_argocd_route_test.go + 1-111_validate_default_argocd_route_test.go — functionally identical: both verify the default openshift-gitops-server Route/TLS secret and both mutate .spec.server.route.tls to Passthrough/None and re-verify. Kept 1-105 (uses the richer routeFixture matchers), deleted 1-111.

3. 1-074_validate_terminating_namespace_block_test.go + 1-102_validate_handle_terminating_namespaces_test.go — same scenario (a managed namespace stuck terminating due to a finalizer must not block reconciliation of other managed namespaces). 1-102 is a strict superset — it does everything 1-074 does (verify RoleBindings appear in the second namespace) plus an actual Application deploy/sync check. Deleted 1-074, kept 1-102.

I've humanly verified that we're not losing test coverage with the result.

PR acceptance criteria:

• Documentation was updated and verified using make serve-docs
• Unit tests were updated
• E2E tests were updated

What type of PR is this?

/kind cleanup

Special notes to the reviewer:

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 37957bb7-8573-46bc-92a0-698f7a4ef845

📥 Commits

Reviewing files that changed from the base of the PR and between abd415a and 9992d0d.

📒 Files selected for processing: 2

• test/openshift/e2e/ginkgo/sequential/1-074_validate_terminating_namespace_block_test.go
• test/openshift/e2e/ginkgo/sequential/1-111_validate_default_argocd_route_test.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

💤 Files with no reviewable changes: 2

• test/openshift/e2e/ginkgo/sequential/1-074_validate_terminating_namespace_block_test.go
• test/openshift/e2e/ginkgo/sequential/1-111_validate_default_argocd_route_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Tests
  • Added end-to-end checks confirming the cluster deployment uses the expected service account and that its service account, cluster role, and cluster role binding are configured correctly.
  • Removed the separate backend permissions test.
  • Removed end-to-end coverage for namespace reconciliation and the default OpenShift route, including route TLS settings and certificate checks.

Changes

OpenShift E2E validation

Layer / File(s)	Summary
Backend service RBAC validation test/openshift/e2e/ginkgo/parallel/1-002-validate_backend_service_test.go, test/openshift/e2e/ginkgo/parallel/1-026-validate_backend_service_permissions_test.go	The backend service test now validates the Deployment service account, ServiceAccount, ClusterRole, and ClusterRoleBinding. The separate permissions test was removed.
Removed sequential E2E tests test/openshift/e2e/ginkgo/sequential/1-074_validate_terminating_namespace_block_test.go, test/openshift/e2e/ginkgo/sequential/1-111_validate_default_argocd_route_test.go	The terminating namespace reconciliation test and default Argo CD route validation test were removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Suggested reviewers: olivergondza

Merge Risk: ⚪ Minimal · up to 9992d

The retained E2E tests preserve the validated behaviors; no actionable merge-blocking risk was established.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly describes the main change: removing duplicated E2E tests.
Description check		The description explains the three duplicate-test removals and the coverage-preservation approach.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jgwest: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.19-kuttl-parallel	9992d0d	link	true	/test v4.19-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.