Repository navigation
Remove the experimental javac mode - #4548
Merged
Merged
Conversation
Closed
Contributor
Author
|
@datho7561 This needs review to ensure I didn't miss anything. I think it's safe and clean but it's always good for a second set of eyes. |
Contributor
|
Okay. Right now it's saying it can't be rebased due to conflicts |
Contributor
|
It might be related to the merge commit; we have some guards against merge commits in some repositories, since they make the git history messy |
datho7561
previously requested changes
Oct 20, 2026
The org.eclipse.jdt.core.javac bundle this depended on required always running with the latest JDK to support the latest Java release, and has stopped being maintained; the bundle is being dropped from the jdt.ls target platform and shipped product. Removes java.jdt.ls.javac.enabled entirely, along with the system properties/--add-opens flags javaServerStarter.ts only sent when it was enabled (these referenced classes -- JavacCompilationUnitResolver, JavacCompilerFactory, DOMJavaSearchDelegate -- that no longer exist in the shipped product), the JDK-25 requirement bump in requirements.ts, and the config-change watcher/normalization code in settings.ts and utils.ts. Also removes java.completion.engine: its only non-default value, dom, only had any effect through the removed javac code path, so with that gone the setting offered no real choice -- selecting ecj or dom already produced identical behavior. Dropped the corresponding telemetry field and documentation in README.md/USAGE_DATA.md. Fixes redhat-developer#4546 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
robstryker
force-pushed
the
issue_4546
branch
from
October 21, 2026 16:22
c5f4a6a to
76ddb3c
Compare
robstryker
dismissed
datho7561’s stale review
October 21, 2026 18:08
References to missing features needed to be removed
datho7561
approved these changes
Oct 21, 2026
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks, Rob!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
java.jdt.ls.javac.enabledentirely: the setting, its launch-time--add-opens/system-property wiring injavaServerStarter.ts(which pointed atJavacCompilationUnitResolver/JavacCompilerFactory/DOMJavaSearchDelegate), the JDK-25 requirement bump it used to force, and its config-change watcher/normalization code.java.completion.engine: its only non-default value,dom, only ever had an effect through the removed javac code path, so with that gone the setting offered no real choice betweenecj/dom— both already produced identical behavior.README.md/USAGE_DATA.mdto drop documentation and telemetry-field references to both settings.org.eclipse.jdt.core.javacbundle is being dropped from the jdt.ls target platform and shipped product in a follow-up eclipse.jdt.ls change; this PR removes the client-side dependency on it first so no released vscode-java build keeps sending now-broken launch flags.Fixes #4546
Test plan
package.jsonvalidated as well-formed JSONtsc --noEmitshows no new errors introduced by this change (pre-existing, unrelated errors from dependency version mismatches remain)CHANGELOG.mdentries🤖 Generated with Claude Code