Skip to content

Return code should be non-zero on error #98

Closed
#99
Closed
Return code should be non-zero on error#98
#99
Labels
bughelp wanted

Description

@vincentbernat
vincentbernat
opened on Apr 15, 2020

Hey!

When running diff2html, I would expect that a fatal error would return a status code different of 0. Currently, the error is printed but the status code says 0.

Activity

  1. rtfpessoa
    added
    bug
    help wanted
    on Apr 15, 2020

  2. rtfpessoa commented on Apr 15, 2020

    @rtfpessoa
    rtfpessoa
    on Apr 15, 2020
    Owner

    I guess I never worked on that part. Eventually I should set process.exitCode

  3. rtfpessoa
    closed this as completedin #99on Apr 17, 2020

  4. rtfpessoa commented on Apr 17, 2020

    @rtfpessoa
    rtfpessoa
    on Apr 17, 2020
    Owner

    Check https://github.com/rtfpessoa/diff2html-cli#exit-status-codes for the codes and you can also start using it in version 5.1.0.

  5. vincentbernat commented on Apr 17, 2020

    @vincentbernat
    vincentbernat
    on Apr 17, 2020
    Author

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bughelp wanted

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions