Skip to content
This repository was archived by the owner on Oct 19, 2018. It is now read-only.
This repository was archived by the owner on Oct 19, 2018. It is now read-only.

changing data base from console regression #21

Open
Open
changing data base from console regression#21

Description

@catmando
catmando
opened on May 2, 2018

This commit 28ef6e6#diff-e50e457d8517d82c3828c357d305a74e seems to have caused a regression.

revert back to simple on_server? returning !Rails.const_defined?('Console')

In debugging this it seem there is some old unreachable code in connection#needs_initialization.

Activity

  1. janbiedermann commented on May 2, 2018

    @janbiedermann
    janbiedermann
    on May 2, 2018
    Contributor

    reverting will probably lead to a performance regression for Puma

  2. janbiedermann commented on May 3, 2018

    @janbiedermann
    janbiedermann
    on May 3, 2018
    Contributor

    i suggest the following:
    @on_server ||= (ARGV & %w[c console]).size == 0

  3. catmando commented on May 4, 2018

    @catmando
    catmando
    on May 4, 2018
    ContributorAuthor

    i think I got it...

  4. catmando
    added 2 commits that reference this issue on May 5, 2018

    closes (hopefully) #21

    a99ab14

    closes #21 #22

    75a2310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions