Skip to content

Rename for consistency: sum → sum_axis, scalar_sum → sum. #346

Closed
Closed
Rename for consistency: sum → sum_axis, scalar_sum → sum.#346
Labels
breaking-change

Description

@bluss
bluss
opened on Aug 26, 2017

I think the sum_axis is a good naming scheme (see map_axis, fold_axis).

  • Add new names sum_axis, mean_axis
  • Rename scalar_sum → sum.

Activity

  1. bluss
    added
    breaking-change
    on Aug 26, 2017

  2. bluss commented on Aug 26, 2017

    @bluss
    bluss
    on Aug 26, 2017
    MemberAuthor

    Will use deprecations to the extent possible (not 100% since we swap names)

  3. bluss commented on Aug 26, 2017

    @bluss
    bluss
    on Aug 26, 2017
    MemberAuthor

    Only alternative I could see would be to use a more evocative naming like map_across, sum_across?

  4. bluss commented on Nov 21, 2018

    @bluss
    bluss
    on Nov 21, 2018
    MemberAuthor

    Fixed by #520

  5. bluss
    closed this as completedon Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking-change

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions