Skip to content

scalar_prod implementation #504

Closed
Closed

Description

@sebasv

I am missing a scalar_prod function. on ArrayBase. This seems straightforward to implement (almost blindly copy/paste scalar_sum), so I will be submitting a pull request. I am not familiar enough with computer engineering to say if an unrolled_prod is a valuable addition as well, so I will just include it in the PR awaiting feedback from someone with more background!

Activity

  1. jturner314 commented on Oct 22, 2018

    @jturner314
    Member

    I am not familiar enough with computer engineering to say if an unrolled_prod is a valuable addition as well

    If you're interested, this is a pretty good article for background, even though it's talking about C++ with the MS compiler instead of Rust with LLVM. Basically, in order to allow the compiler to perform the sum/product using SIMD even with strict floating-point behavior, it's helpful to explicitly unroll and reorder the sum/product manually.

  2. sebasv commented on Oct 23, 2018

    @sebasv
    ContributorAuthor

    That seems like a very nice read, thank you!

  3. jturner314 commented on Oct 27, 2018

    @jturner314
    Member

    Implemented in #505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions