Repository navigation
Remove unused var from VarExpr - #1277
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
var from VarExprvar from VarExpr
Joao-Dionisio
enabled auto-merge
October 19, 2026 12:27
Joao-Dionisio
self-requested a review
October 19, 2026 12:27
Joao-Dionisio
approved these changes
Oct 19, 2026
Joao-Dionisio
disabled auto-merge
October 19, 2026 12:28
Zeroto521
added a commit
to Zeroto521/PySCIPOpt
that referenced
this pull request
Oct 20, 2026
Hand-merged conflicts in CHANGELOG.md, expr.pxi, scip.pxd, scip.pyi (no conflict markers in working tree). Key changes from upstream f5a761d: - scipopt#1267: readonly fields on SumExpr/ProdExpr - scipopt#1256: dual fix - scipopt#1273: addConsLinear - scipopt#1277: remove VarExpr.var - New: stubs/baseline.sh, requirements/types.txt, pylock.types.toml, tests/@types/expr.mypy.out, scripts/generate_expr_type_tests.py M4 core: Variable(ExprLike), ExprLike base with as_expr/expr_view, __init__ throws NotImplementedError on Variable. Bug fix: Expr.__add__/__mul__ now delegate to GenExpr when other is GenExpr, avoiding PyNumber_Add recursion that caused stack overflow when computing Expr + GenExpr (e.g., 2*x + exp(x)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VarExprinsrc/pyscipopt/expr.pxideclarescdef public varbut never assigns it.__init__only doesself.children = [var].