Repository navigation
Conversation
Evaluate PowExpr values with C's pow function and raise ZeroDivisionError for zero raised to a negative exponent. Add regression coverage for negative exponents and division by zero.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
PowExpr._evaluate via the C-level API
Rename the evaluated operand from `val` to `base` in `PowExpr._evaluate` for clearer naming.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1278 +/- ##
==========================================
+ Coverage 57.91% 58.08% +0.17%
==========================================
Files 26 27 +1
Lines 5807 6029 +222
==========================================
+ Hits 3363 3502 +139
- Misses 2444 2527 +83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Python
**in PowExpr._evaluate with the Cpow()function and keep the Python semantics for raising zero to a negative power.PowExpr._evaluateover(x + x + 1) ** -2.0with a fixed solution,n = 5_000_000, min of 3 rounds:**)c_pow+ guard)~25-30% speedup.