Repository navigation
Add deprecation warning to deprecated methods #1395
Description
example below from slack_sdk/web/client.py
why not delete them are at least add docstr or a warning message to the log these are deprecated!
# --------------------------
# Deprecated: channels.*
# You can use conversations.* APIs instead.
# https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api
# --------------------------
def channels_archive(
self,
*,
channel: str,
**kwargs,
) -> SlackResponse:
"""Archives a channel."""
kwargs.update({"channel": channel})
kwargs = _remove_none_values(kwargs)
return self.api_call("channels.archive", json=kwargs)
Activity
[-]why does the code contains deprecated methods, and even without a warning...[/-][+]Add deprecation warning to deprecated methods[/+]filmaj commentedon Aug 9, 2023
Hey @omerkarpas , thanks for the suggestion! I think adding a deprecation warning to these old API methods is a good idea.
Feel free to send a PR! 🙇
github-actions commentedon Sep 11, 2023
👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.
github-actions commentedon Sep 25, 2023
As this issue has been inactive for more than one month, we will be closing it. Thank you to all the participants! If you would like to raise a related issue, please create a new issue which includes your specific details and references this issue number.