Repository navigation
Fix Crawlinks issue during build - #459
Merged
Merged
Conversation
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
danieljcafonso
approved these changes
Feb 12, 2024
LadyBluenotes
approved these changes
Feb 12, 2024
1 of 2 tasks
ryansolid
added a commit
that referenced
this pull request
Oct 22, 2026
…1665) * docs: sync diagnostics pages and the Vite plugin's test environment - Regenerate the diagnostics reference from solid next 6cca8b57: adds STORE_WRITE_OUTSIDE_SETTER (#4194) and UNCOMMITTED_INPUT_OVERWRITTEN (#4205), drops BINDING_SLOT_POSITION (binding slots were removed), and picks up skill edits to EFFECT_RELAY_TEAR, LOWERCASE_EVENT_ATTRIBUTE, REACTIVITY_HALTED, SSR_BOUNDARY_WATERFALL and SSR_LIVE_HOLE_LATCHED. The generator's FIX_STARTS entry for SSR_BOUNDARY_WATERFALL follows the skill's new capitalization, and the dead BINDING_SLOT_POSITION entry goes. - The Vite plugin no longer defaults test.environment to jsdom (vite-plugin-solid #459): the testing guide drops the "browser mode still needs jsdom" note and troubleshooting entry, browser mode no longer installs jsdom, and a new entry covers `document is not defined`. The plugin options reference and the Solid 1 migration guide say to set the environment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9d4iekBWmtH343gNAGJpd * docs: regenerate diagnostics against solid-js@2.0.0-rc.17 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9d4iekBWmtH343gNAGJpd --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitro can't crawl
<A>links and it's causing bad prerendering. It may be causing a few cascade issues with the deployed site.possibly related to: #455