Skip to content

reduce volume API calls in the CSI driver - #1658

Open
ftl wants to merge 8 commits into
mainfrom
rework_volume_api
Open

reduce volume API calls in the CSI driver#1658
ftl wants to merge 8 commits into
mainfrom
rework_volume_api

Conversation

@ftl

@ftl ftl commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

How to categorize this PR?

/kind enhancement

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

What this PR does / why we need it:
This PR removes several client-side checks that are already handled in the STACKIT IaaS backend. It adds IN_USE as a useable state for attachments.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Sep 14, 2026
@ske-prow

ske-prow Bot commented Sep 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breuerfelix for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 14, 2026
@ftl

ftl commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

/hold double check with IaaS before merging

@ske-prow ske-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 14, 2026
@ftl
ftl force-pushed the rework_volume_api branch from fed99be to 669af46 Compare September 21, 2026 10:00
@dergeberl

dergeberl commented Oct 7, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-v1.37

@stackit-ske

stackit-ske commented Oct 7, 2026

Copy link
Copy Markdown

@dergeberl: once the present PR merges, I will cherry-pick it on top of release-v1.37 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ftl
ftl force-pushed the rework_volume_api branch from 669af46 to 546748c Compare October 15, 2026 11:41
@ske-prow ske-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2026
@ftl
ftl requested a review from a team October 15, 2026 12:02
dergeberl
dergeberl reviewed Oct 16, 2026
View reviewed changes
Comment thread pkg/csi/blockstorage/controllerserver.go
Comment thread pkg/csi/blockstorage/controllerserver.go Outdated
Comment thread pkg/csi/blockstorage/controllerserver.go Outdated
Comment thread pkg/csi/blockstorage/controllerserver.go
@ske-prow ske-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2026
ftl and others added 7 commits October 20, 2026 10:28
@ftl
remove the client side checks that are already done on the IaaS side;
fcd29e2 
handle IN_USE as useable attachment status
@ftl
do not set encryptionConfig when copying from backup, snapshot, or
93b1cce 
volume source
@ftl
add logging
b6250cc
@ftl
fix compile errors after rebase
883b3da 
Signed-off-by: Florian Thienel <florian.thienel@inovex.de>
@ftl @dergeberl
Update pkg/csi/blockstorage/controllerserver.go
8b40c7d 
Co-authored-by: Maximilian Geberl <48486938+dergeberl@users.noreply.github.com>
@ftl
log only for encrypted volumes
3ca8f75 
Signed-off-by: Florian Thienel <florian.thienel@inovex.de>
@ftl
fix inconsistent error message
41f14fa 
Signed-off-by: Florian Thienel <florian.thienel@inovex.de>
@ftl
ftl force-pushed the rework_volume_api branch from ff468e3 to 41f14fa Compare October 20, 2026 08:28
@ske-prow ske-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2026
@ftl
update test fixture
48428b7 
Signed-off-by: Florian Thienel <florian.thienel@inovex.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dergeberl dergeberl dergeberl left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ftl @dergeberl @stackit-ske