Error when passing ErrorStackParser.parse as callback to Array.prototype.map #41

Activity

1. tao-cumplido commented on Nov 29, 2017

   

   tao-cumplido

   on Nov 29, 2017

   Author

   More actions

   I figured out why it doesn't work, I didn't know that map receives an optional second argument to be used as this so when used like this it works:

   errors.map(ErrorStackParser.parse, ErrorStackParser).forEach(console.log)

   I think the changes to the code would be minimal to support the use case without passing the thisArg. Something like this:

   function ErrorStackParser$$parse(error) {
       // ...
   }
   
   // other methods
   
   return {
       parse: ErrorStackParser$$parse
   }
2. fmartin5 commented on Feb 2, 2018

   

   fmartin5

   on Feb 2, 2018

   More actions

   I agree with you @tao-cumplido. As far as I understand, ErrorStackParser is meant to be used as a singleton like e.g. the Math object,
   so I think its methods should be independant of the this binding.

   This could also be done using .bind() to ensure the this binding inside parse() always refer to ErrorStackParser:

       // ... 
   
       parse: function ErrorStackParser$$parse(error) {
           // ... code
       }.bind(ErrorStackParser),

   However .bind() is not supported in old environments.
3. eriwen

   added

   a:feature

   on Jan 5, 2020