Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External payload uploads can fail repeatedly when escaped workflow or activity IDs produce S3 keys longer than 1,024 bytes. Fall back to a namespace-scoped hash key in that case, and write
/ns/nullfor empty namespaces. Existing saved references remain readable.Correct the aioboto3 permission example: uploads check object existence first, so writers need
s3:GetObjectands3:ListBucketas well ass3:PutObject. Access-denied responses continue to fail rather than being treated as missing objects.Includes a changelog fragment and tests for name-length boundaries, escaped names, namespace separation, old references, and access-denied responses. Related naming feedback: #1980 (comment).
Validation
poe test -s -n 0 tests/contrib/aws/s3driver: 86 passed on Python 3.12 and 3.14, including workflow/activity tests against the local S3 test server.poe lintpassed.