Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the key isn't in the file,
unset_key(anddotenv unset) correctly returns(None, key)/ exits with 1 and "key doesn't exist", but by then it has already replaced the file throughrewrite(). A no-op unset therefore:.envinto a regular file (and the new file has mode 0600),For example, with
app/.env -> ../shared/.envandshared/.envcontainingDB_HOST=localhost\r\nDB_PORT=5432\r\n, using python-dotenv 1.2.4:After this, a deploy script doing
dotenv unset OLD_KEY || truesilently cuts the link to the shared file.The fix abandons the rewrite when nothing was removed:
rewrite()already discards its temporary file and leaves the original untouched when the body raises, so the file is read and parsed once, as before, and the warning and return value are unchanged.Added two tests: one checks that a CRLF file keeps its bytes and inode, the other that a symlink stays a symlink (skipped on Windows like the existing symlink tests). Both fail without the change.