Repository navigation
Fix: Make the TypedPython develop CI deterministic - #211
Merged
Merged
Conversation
…n scope, pyc reuse)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The develop runs after #205 and #209 failed (typedpython.yml). Three causes, none a product defect:
test_importgate.py::test_clean_module_imports_and_is_cached_by_content(ubuntu, also on the Fix: An ArrayParam function that can run user code stays interpreted (#203) #205 run):.pyccheck compares the source mtime in whole seconds and its size, so the import ran the stale bytecode.test_threadsanitizer_reports_nothing_on_the_extension(ubuntu): 6 reports.test_threadsanitizer_sees_a_plain_epochstill passes with the filter, so a real race in our code is still reported.test_mutant_without_the_dict_critical_section_is_caught(macOS): the mutant was not caught on the CI runner.race_mutantand excluded from CI (-m "not measurement and not race_mutant"). They still run locally.Verification (local, 3.15.0rc1 free-threaded): test_free_threaded.py and test_importgate.py: 32 passed, including both race mutants and both TSan tests.