Repository navigation
Fix: The buffer tests run without numpy; CI installs numpy for the numpy pins - #229
Merged
Merged
Conversation
…mpy pins (#225 follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red develop run after #225:
test_buffer_arrays.pyimported numpy at the top, and its test module source imported numpy too, but the CI venv has no numpy.NDArrayparameter stays an object; a numpy array passed to an array.array parameter takes the object path) move totest_buffer_numpy.py, which usespytest.importorskip("numpy").test_buffer_arrays.pyno longer needs numpy.typedpython.ymlinstalls numpy in all three jobs, so CI still runs the numpy pins.Verification (3.15.0rc1t): without numpy, 49 passed and 1 skipped; with numpy, 51 passed.