Repository navigation
ssd1306, uc8151: clear the display only when FillRectangle covers it - #920
Open
hervenicol wants to merge 1 commit into
Open
hervenicol wants to merge 1 commit into
hervenicol wants to merge 1 commit into
Conversation
FillRectangle calls ClearDisplay for a black rectangle that ends at the bottom-right corner of the display. The check does not look at the start of the rectangle. Thus a black line or a small black rectangle at the bottom-right corner clears the whole display. The full-screen shortcut now also requires the rectangle to start at 0,0. Add tests for FillRectangle in both drivers.
hervenicol
marked this pull request as ready for review
October 18, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FillRectangleinssd1306anduc8151has a shortcut: it callsClearDisplay()for a black rectangle that covers the display.The check is
x+width == dw && y+height == dh, so it only looks at where the rectangle ends. Any black rectangle that ends at the bottom-right corner clears the whole display.For example, on a 128x64 ssd1306,
FillRectangle(100, 63, 28, 1, black)clears all 8192 pixels, not 28.This change adds
x == 0 && y == 0to the check.A full-screen black fill still uses
ClearDisplay().I added unit tests for both drivers: