Skip to content

Use patched Node 22.23.4 for signature parity - #92

Merged
kvz merged 1 commit into
mainfrom
node-security
Oct 21, 2026
Merged

kvz merged 1 commit into
mainfrom
node-security

Conversation

@kvz

@kvz kvz commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Signature-parity tooling needs the October Node.js security fixes, including the native Brotli decoder RCE (CVE-2026-111497). Node.js identifies 22.23.4 as the patched Node 22 release.

Pin CI parity tooling to Node 22.23.4. In Docker, copy the Node binary and npm package from the official node:22.23.4-bookworm-slim image into the existing Ruby 4 base, create the npm/npx links, and retain the existing npm@latest upgrade. This makes the Node input explicit instead of relying on the floating NodeSource 22.x installer.

Validation on framework1:

  • Council review: no issues found.
  • Full Docker build: Ruby 4.0.7, Node 22.23.4, npm/npx 12.2.0.
  • TEST_NODE_PARITY=1 RUBY_SDK_E2E=0 COVERAGE=0 bundle exec rake test TESTOPTS=--verbose: 140 runs, 364 assertions, zero failures/errors; only the optional live upload skipped. The CLI signature and Smart CDN parity checks ran using Node 22.23.4.
  • bundle exec standardrb and git diff --check: passed.
  • Container runtime probes: Node version, npm/npx links, shared libraries, Brotli roundtrip and malformed-stream rejection, SHA-256, and TLS context creation passed.

The Docker test command did not load .env or forward credentials. CI passed on commit 57cc234 across Ruby 3.1, 3.2, 3.3, 3.4 and 4.0, plus the configured e2e job. Ruby 4.0 ran all parity checks on Node 22.23.4 (140 runs, 364 assertions; only the live upload skipped in that unit-suite job). The separate e2e job passed its live upload: 1 run, 14 assertions, zero skips.

🤖 Claimed by kvz on framework1/ruby-sdk since 2026-10-21 · resume: codex resume 01a15f49-fea9-7951-9efa-59362f857d7c

@kvz kvz self-assigned this Oct 21, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (966c15a) to head (57cc234).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files           9        9           
  Lines         363      363           
  Branches       46       46           
=======================================
  Hits          359      359           
  Misses          1        1           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kvz
kvz merged commit a5135b7 into main Oct 21, 2026
6 checks passed
@kvz
kvz deleted the node-security branch October 21, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants