Repository navigation
Use patched Node 22.23.4 for signature parity - #92
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 9 9
Lines 363 363
Branches 46 46
=======================================
Hits 359 359
Misses 1 1
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signature-parity tooling needs the October Node.js security fixes, including the native Brotli decoder RCE (CVE-2026-111497). Node.js identifies 22.23.4 as the patched Node 22 release.
Pin CI parity tooling to Node 22.23.4. In Docker, copy the Node binary and npm package from the official
node:22.23.4-bookworm-slimimage into the existing Ruby 4 base, create the npm/npx links, and retain the existingnpm@latestupgrade. This makes the Node input explicit instead of relying on the floating NodeSource 22.x installer.Validation on
framework1:TEST_NODE_PARITY=1 RUBY_SDK_E2E=0 COVERAGE=0 bundle exec rake test TESTOPTS=--verbose: 140 runs, 364 assertions, zero failures/errors; only the optional live upload skipped. The CLI signature and Smart CDN parity checks ran using Node 22.23.4.bundle exec standardrbandgit diff --check: passed.The Docker test command did not load
.envor forward credentials. CI passed on commit57cc234across Ruby 3.1, 3.2, 3.3, 3.4 and 4.0, plus the configured e2e job. Ruby 4.0 ran all parity checks on Node 22.23.4 (140 runs, 364 assertions; only the live upload skipped in that unit-suite job). The separate e2e job passed its live upload: 1 run, 14 assertions, zero skips.🤖 Claimed by kvz on
framework1/ruby-sdksince 2026-10-21 · resume:codex resume 01a15f49-fea9-7951-9efa-59362f857d7c