Skip to content

docs(detection): use a workspace-relative path in the local server example - #211

Open
rudycelekli wants to merge 1 commit into
uber:mainfrom
rudycelekli:fix/detection-readme-local-server-path
Open

rudycelekli wants to merge 1 commit into
uber:mainfrom
rudycelekli:fix/detection-readme-local-server-path

Conversation

@rudycelekli

@rudycelekli rudycelekli commented Oct 19, 2026 •

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Related issue: N/A (found by reading the code; reproduced on main at 6b33dff)

What changed?
README example uses the ../../../../ prefix, plus a one-line note on why.

Why?
Detection/README.md "Option 2: Local Custom Servers" registers args_template: ["run","fastmcp","run","context_providers/source_codes/mcp_servers_0/your_server/your_server.py"]. main_benchmark.py writes .mcp.json into benchmark/adr_bench_*/task_XXX/workspace/ and runs claude with cwd=workspace (_execute_command, create_mcp_config), so that path does not exist from the server's cwd and the server fails to start. All 116 uv entries in mcp_servers_registry.json use ../../../../context_providers/....

How did you test it?

  • Reproduction: probe with MCPServerManager.create_mcp_config in Detection/benchmark/adr_bench_probe/task_001/workspace using arxiv_toolkit's real script: README-style arg -> "exists from workspace cwd: False"; registry-style arg -> True. (Probe dir removed afterwards.)
  • Test suite: not run (docs-only change).
  • Not tested: actually launching a new server through claude.

Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.

AI assistance: Claude Code (model Claude Opus 5.5) found this bug, wrote the fix and test, and drafted this description; submitted by @rudycelekli.

🤖 Generated with Claude Code

…ample

main_benchmark.py writes each task's .mcp.json into
benchmark/adr_bench_*/task_XXX/workspace/ and runs claude from there,
so a server script path relative to Detection/ does not exist from the
server's working directory. The README example registered
"context_providers/source_codes/..." and the server would fail to
start. Use the "../../../../" prefix that every local entry in
mcp_servers_registry.json uses, and say why.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants