Repository navigation
docs(detection): use a workspace-relative path in the local server example - #211
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
…ample main_benchmark.py writes each task's .mcp.json into benchmark/adr_bench_*/task_XXX/workspace/ and runs claude from there, so a server script path relative to Detection/ does not exist from the server's working directory. The README example registered "context_providers/source_codes/..." and the server would fail to start. Use the "../../../../" prefix that every local entry in mcp_servers_registry.json uses, and say why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
README example uses the
../../../../prefix, plus a one-line note on why.Why?
Detection/README.md "Option 2: Local Custom Servers" registers
args_template: ["run","fastmcp","run","context_providers/source_codes/mcp_servers_0/your_server/your_server.py"]. main_benchmark.py writes .mcp.json intobenchmark/adr_bench_*/task_XXX/workspace/and runsclaudewith cwd=workspace (_execute_command,create_mcp_config), so that path does not exist from the server's cwd and the server fails to start. All 116uventries in mcp_servers_registry.json use../../../../context_providers/....How did you test it?
claude.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.
AI assistance: Claude Code (model Claude Opus 5.5) found this bug, wrote the fix and test, and drafted this description; submitted by @rudycelekli.
🤖 Generated with Claude Code