Repository navigation
Conversation
Scan build observations for existing fix IDs, submit an eligible open issue, and associate the returned ID through entity CAS. Return submission errors without an ID for normal queue handling; document caller-owned retry policy. Test Plan: Run ./tool/bazel test //stovepipe/controller/fix:go_default_test and make lint check-tidy check-gazelle. Revert Plan: Revert this commit.
This was referenced Oct 23, 2026
mnoah1
added this pull request to stack #937
October 23, 2026 21:04
mnoah1
marked this pull request as ready for review
October 23, 2026 21:10
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 23, 2026 21:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Submit a repair for a newly opened issue while initially limiting recorded repairs to one issue per build.
Once we get this working end to end for the first failure on each build, we can build out additional logic that can introduce multiple parallel fixes for different issues in the same build.
What?
Add a fix controller that scans the build's durable observations, skips builds with a recorded fix ID, and submits one currently open issue first seen in that build. Persist the executor's returned ID with entity CAS, including IDs returned alongside an error. Errors without an ID follow normal queue error handling; concurrent submissions or retries can produce duplicate outbound calls.
Test Plan
Run
./tool/bazel test //stovepipe/controller/fix:go_default_test. Tests cover pagination, existing repair associations, issue recovery, executor errors, and CAS conflicts. Runmake lint check-tidy check-gazelle.Revert Plan
Revert the queue-wiring layer first, then this commit.
Stack