Skip to content

FixPunct in enhanced deps #47

Closed
Closed

Description

@gossebouma

I rely on udapy -s ud.FixPunct to re-attach punctuation according to ud guidelines.This script does not fix attachment in enhanced deps, however. It is not very complicated to remedy this (ie simply copy the modified attachment targets to the enhanced deps field) but it might be nice to include this in the script. Or is there some flag I am missing?
I don't think there is ever anything that affects punctuation in enhanced, so this should be safe.

Activity

  1. martinpopel commented on Mar 2, 2018

    @martinpopel
    Contributor

    Good idea to include enhanced deps as well. Either send a PR or wait until I'll get to it.

  2. martinpopel commented on Mar 9, 2018

    @martinpopel
    Contributor

    Sorry it took me so long to add 4 lines of code.
    I thought it will be more complicated (traversing the enhanced deps with multiple parents and empty nodes), but if we think that for PUNCT node the enhanced deps should always follow the basic deps, then the copying is really easy (it overwrites whatever was in enh deps for PUNCT nodes, but I guess that's ok).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions