Repository navigation
Conversation
…actories
A component constructor parameter decorated with `@Inject('TOKEN')` compiled to
`ɵɵinvalidFactoryDep(index)`, so creating the component threw. Like ngtsc, the
factory now injects the string itself: `ɵɵdirectiveInject('TOKEN')`, with the
parameter's other flags (`@Optional()`, `@Self()`, ...). Directives, pipes and
injectables already did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A component constructor parameter decorated with a string token,
@Inject('API_URL'), compiled toɵɵinvalidFactoryDep(index), so creating the component threw at runtime. Directives, pipes and injectables already injected the string.Like ngtsc, the component factory now injects the string itself, with the parameter's other flags:
tests/inject_string_token_test.rschecks the component, directive, pipe and injectable factories against ngc's output for the same classes; the component case fails without the change.