Repository navigation
Conversation
…rt on Linux `xtool.yml` gains `prepare`, a list of shell commands run in the package directory before planning, so a package that depends on generated inputs (such as a binary target built by another compiler) builds with `xtool dev` alone. On non-Apple hosts, the generated builder package links the platform's compiler-rt builtins archive from the installed Darwin SDK. Apple's clang driver always links it; the Linux clang that drives the link here does not, so any dependency using `__builtin_available` (a Kotlin/Native framework, for example) failed with `undefined symbol: ___isPlatformVersionAtLeast`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
xtool.ymlgainsprepare, a list of shell commands run in the package directory before planning; a failing command stops the build. Documented in Control.md. Packages that depend on generated inputs, such as a binary target produced by another compiler, previously needed a wrapper script around xtool; withprepare,xtool devalone builds and installs them.libclang_rt.ios.a,.iossim.aor.osx.a, chosen from the build triple). Apple's clang driver always links these builtins; the Linux clang that drives the link here does not, so any dependency using__builtin_available(every Kotlin/Native framework, among others) fails withundefined symbol: ___isPlatformVersionAtLeast. The SDK bundle already carries Xcode's toolchain with the archive.How was it tested?
PackerTests.compilerRTLibraryNameFollowsBuildTriple(unit).preparestep builds withxtool dev build --ipa(the generated builder package carries the compiler-rt path, and the link no longer needs the archive copied into the host clang's resource directory), then installs withxtool installand launches on an iPhone.AI tool usage
How much of this PR was AI-assisted? (check one)
Opened as a draft per the template; I will mark it ready after reviewing the diff myself.