Skip to content

Search doesn't work on Templates #357

Closed

Description

#325 added search functionality across the Features, Templates, and Collections pages. The search works well on Features and Collections but doesn't seem to work for me on Templates.

Samruddhi Khandale (@samruddhikhandale) do you see the same behavior? And do you have any recommendations for how to test this locally (as mentioned in #325, I can test Collections pretty easily since they load when I build and run the site locally, but Features and Templates don't populate locally for me when testing).

Activity

  1. samruddhikhandale commented on Feb 22, 2024

    @samruddhikhandale
    Member

    Samruddhi Khandale (@samruddhikhandale) do you see the same behavior?

    Yes, I see the "Search" not working for Templates. However, for Features and collections it works perfectly.

    I can test Collections pretty easily since they load when I build and run the site locally, but Features and Templates don't populate locally for me when testing

    Even I tried testing locally and saw the same here, I'd need to investigate the problem.

    The issue with the search functionality is that it's trying to access a third td element in each row, which doesn't exist. The table only has two td elements per row: one for the template name and one for the maintainer. This line seems problematic.

  2. bamurtaugh commented on Feb 22, 2024

    @bamurtaugh
    MemberAuthor

    The issue with the search functionality is that it's trying to access a third td element in each row, which doesn't exist. The table only has two td elements per row: one for the template name and one for the maintainer. This line seems problematic.

    Ah that's a great catch, thank you! Opened #358.

  3. bamurtaugh commented on Feb 22, 2024

    @bamurtaugh
    MemberAuthor

    Unfortunately looks like the latest PR didn't fix things ☹ so reopening this issue.

  4. bamurtaugh commented on Feb 22, 2024

    @bamurtaugh
    MemberAuthor

    Found another reference to a non-existent column so opened another PR: #359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions