You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#325 added search functionality across the Features, Templates, and Collections pages. The search works well on Features and Collections but doesn't seem to work for me on Templates.
Samruddhi Khandale (@samruddhikhandale) do you see the same behavior? And do you have any recommendations for how to test this locally (as mentioned in #325, I can test Collections pretty easily since they load when I build and run the site locally, but Features and Templates don't populate locally for me when testing).
Yes, I see the "Search" not working for Templates. However, for Features and collections it works perfectly.
I can test Collections pretty easily since they load when I build and run the site locally, but Features and Templates don't populate locally for me when testing
Even I tried testing locally and saw the same here, I'd need to investigate the problem.
The issue with the search functionality is that it's trying to access a third td element in each row, which doesn't exist. The table only has two td elements per row: one for the template name and one for the maintainer. This line seems problematic.
The issue with the search functionality is that it's trying to access a third td element in each row, which doesn't exist. The table only has two td elements per row: one for the template name and one for the maintainer. This line seems problematic.
Activity
samruddhikhandale commentedon Feb 22, 2024
Yes, I see the "Search" not working for Templates. However, for Features and collections it works perfectly.
Even I tried testing locally and saw the same here, I'd need to investigate the problem.
The issue with the search functionality is that it's trying to access a third
tdelement in each row, which doesn't exist. The table only has twotdelements per row: one for the template name and one for the maintainer. This line seems problematic.bamurtaugh commentedon Feb 22, 2024
Ah that's a great catch, thank you! Opened #358.
bamurtaugh commentedon Feb 22, 2024
Unfortunately looks like the latest PR didn't fix things ☹ so reopening this issue.
bamurtaugh commentedon Feb 22, 2024
Found another reference to a non-existent column so opened another PR: #359.