Repository navigation
Add search functionality on collections, Features, Templates - #325
Merged
Brigit Murtaugh (bamurtaugh) merged 19 commits intoFeb 22, 2024
Merged
Conversation
in collections.html
collections.html
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thank you so much for adding these changes, this will be so helpful for folks! 🎉
Left few comments.
Member
Author
|
Ah sorry for any confusion! This was one of my demo scenarios during Ignite and a sample PR - I'll close this 😄 |
Member
|
Ah! 🤦♀️ Brigit Murtaugh (@bamurtaugh) FYI, this is really a good PR, adding a |
Member
Author
|
Thanks so much for the feedback Samruddhi Khandale (@samruddhikhandale) and I agree we should reopen, especially as part of devcontainers/spec#405! Let me address your feedback and then re-request review. |
This was referenced Feb 17, 2024
4 of 5 tasks
Samruddhi Khandale (samruddhikhandale)
approved these changes
Feb 22, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks great, thank you! ⚡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds search functionality for collections, Templates, and Features.
Added an input field for searching tables
Implemented JavaScript logic to filter the table rows based on the search input
These changes improve the user experience by allowing users to easily search and find specific items in each table.