Repository navigation
fix: keep C++ exceptions and string pins inside the media JNI layer - #439
Merged
Merged
Conversation
Every media entry point now runs behind a boundary that turns C++ exceptions into Java ones, Java strings are held by an RAII wrapper, and a recorder track that fails to be added releases its frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media module's JNI entry points had no C++ exception boundary, so a failed allocation (e.g. copying the source string in
MediaReader.open) would end the process, and the Java string's characters stayed pinned.media/JniBoundary.h:CallFromJavaturns C++ exceptions into Java ones (bad_alloc→OutOfMemoryError), plus RAIIJavaStringCharsandLocalRef, and one allocation-freeThrowJavaException. No dependency on the WebRTC library.MediaReader.info()makes no JNI call after a failedNewStringUTF.MediaRecorder::AddTrackreleases the handed-over frames when it fails, andStartstays stoppable when its thread cannot be created.AllocationFaulthook fails the next string copy on demand.