Repository navigation
fix: cover the remaining native failure paths of the media module - #442
Merged
Merged
Conversation
A recorder whose writer cannot start stays idle, a frame that cannot be queued on a WebRTC thread is dropped instead of thrown into it, a player that fails to start loses its observer first, exception text reaches Java as ASCII, and MediaFileSource cleans up on errors too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #439, for the failure paths it left open:
OnEncodedFrame, called by WebRTC through the C interface, no longer lets a C++ exception escape into WebRTC: a frame that cannot be queued is dropped and a key frame requested.createdrops its observer before it is released, also when a C++ exception unwinds.ThrowNewexpects modified UTF-8.MediaFileSourcecleans up onErroras well, and the FFmpeg entry points run behind the boundary too.AllocationFaultcan also fail a general allocation or a thread start, with tests for each path.